sbt-dotty: Make launchIDE work offline #5133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each Code extension we require, we start by trying to install or upgrade the extension. If this fails we check if an existing version of the extension exists. If this also fails we throw an exception. This ensures that we're always running the latest version of the extension but that we can still work offline.
0.2.4 has been released.
Duhemm
approved these changes
Sep 21, 2018
| */ | ||
| def runProcess(cmd: Seq[String], wait: Boolean = false, directory: File = null): Unit = { | ||
| def runProcess(cmd: Seq[String], wait: Boolean = false, directory: Option[File] = None, outputCallback: Option[BufferedReader => Unit] = None): Unit = { | ||
| val pb = new ProcessBuilder(prepareCommand(cmd): _*).inheritIO() |
There was a problem hiding this comment.
We don't need .inheritIO() anymore
We now explicitly set .redirect{Input,Output,Error}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each Code extension we require, we start by trying to install or
upgrade the extension. If this fails we check if an existing version of
the extension exists. If this also fails we throw an exception. This
ensures that we're always running the latest version of the extension
but that we can still work offline.